Open
Conversation
juanRodriguez17
requested review from
agustinkoll-rootstrap,
amaury901130 and
tarruk
| } | ||
| }, | ||
| child: child, | ||
| child: Stack( |
Contributor
There was a problem hiding this comment.
Podemos mover estos cambios para el modulo example asi es mas facil de quitar cuando empezamos un proyecto nuevo usando el template
| @@ -1 +1 @@ | |||
| {"info":"This is a generated file; do not edit or check into version control.","plugins":{"ios":[{"name":"package_info_plus","path":"/Users/fabianvalencia/.pub-cache/hosted/pub.dev/package_info_plus-4.2.0/","native_build":true,"dependencies":[]},{"name":"permission_handler_apple","path":"/Users/fabianvalencia/.pub-cache/hosted/pub.dev/permission_handler_apple-9.1.4/","native_build":true,"dependencies":[]}],"android":[{"name":"package_info_plus","path":"/Users/fabianvalencia/.pub-cache/hosted/pub.dev/package_info_plus-4.2.0/","native_build":true,"dependencies":[]},{"name":"permission_handler_android","path":"/Users/fabianvalencia/.pub-cache/hosted/pub.dev/permission_handler_android-10.3.6/","native_build":true,"dependencies":[]}],"macos":[{"name":"package_info_plus","path":"/Users/fabianvalencia/.pub-cache/hosted/pub.dev/package_info_plus-4.2.0/","native_build":true,"dependencies":[]}],"linux":[{"name":"package_info_plus","path":"/Users/fabianvalencia/.pub-cache/hosted/pub.dev/package_info_plus-4.2.0/","native_build":false,"dependencies":[]}],"windows":[{"name":"package_info_plus","path":"/Users/fabianvalencia/.pub-cache/hosted/pub.dev/package_info_plus-4.2.0/","native_build":false,"dependencies":[]},{"name":"permission_handler_windows","path":"/Users/fabianvalencia/.pub-cache/hosted/pub.dev/permission_handler_windows-0.1.3/","native_build":true,"dependencies":[]}],"web":[{"name":"package_info_plus","path":"/Users/fabianvalencia/.pub-cache/hosted/pub.dev/package_info_plus-4.2.0/","dependencies":[]}]},"dependencyGraph":[{"name":"package_info_plus","dependencies":[]},{"name":"permission_handler","dependencies":["permission_handler_android","permission_handler_apple","permission_handler_windows"]},{"name":"permission_handler_android","dependencies":[]},{"name":"permission_handler_apple","dependencies":[]},{"name":"permission_handler_windows","dependencies":[]}],"date_created":"2024-05-02 16:35:44.210631","version":"3.19.3"} No newline at end of file | |||
Contributor
There was a problem hiding this comment.
podes agregar los .flutter-plugins y flutter-plugins dependencies a los gitignore?
| class NotificationCubit extends Cubit<NotificationState?> { | ||
| NotificationCubit() : super(null); | ||
|
|
||
| void showNotification({ |
Contributor
There was a problem hiding this comment.
te parece agregarle unit test a showNotification y a clearNotification?
agustinkoll-rootstrap
suggested changes
Aug 1, 2025
Contributor
agustinkoll-rootstrap
left a comment
agustinkoll-rootstrap
left a comment
There was a problem hiding this comment.
Excelente trabajo! solo me parece que habria que mover los cambios de app para example, te parece bien?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces a new notification service that handles managing local notifications and syncing notification preferences with the backend
This service aims to introduce to the Flutter base repository a new way to ensure users don't miss important events, centralize notification logic for better maintainability and use it for future projects.
Changes Made
NotificationsServiceadded. This new service class encapsulates all logic related about show and close notifications across the hole app.NotificationStatusfor the different types of notifications. Widely modifiable to add more in the future if required.NotificationCubitandNotificationStatefor the management of the different states.NotificationWidgetwith progress bar animation in order to build the notificationsAppwidget the usage of theNotificationWidgetfor showing the different notifications producedIssue [Flutter Community board]
Preview
Screen_recording_20250731_153148.mp4
@rs-gpt-review Describe the changes in this PR. Recommend improvements (including code improvements), possible memory leaks, and best practices.